Repository navigation
docs: fix dead Khronos render fidelity link in README - #5225
Open
farisbasha wants to merge 1 commit into
Open
farisbasha wants to merge 1 commit into
farisbasha wants to merge 1 commit into
Conversation
The glTF Render Fidelity site no longer has a /comparison/ page (404); the model comparison now lives at the site root.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Quality Comparisons" link in
packages/model-viewer/README.mdpoints tohttps://github.khronos.org/glTF-Render-Fidelity/comparison/, which returns 404. The Khronos site was rebuilt and the per-model renderer comparison (including model-viewer) is now at the root,https://github.khronos.org/glTF-Render-Fidelity/.Checked with
curl -sIwithout following redirects: old URL 404, new URL 200.Side note, not changed here: the "Demo" link next to it (
https://model-viewer.glitch.me) returns 410 since Glitch stopped hosting projects. Glitch is also referenced in the issue template and the docs site, so that probably needs a maintainer decision on what the demo should be.